Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Enable mock mining in Epoch 3.0 #5029

Merged
merged 5 commits into from
Aug 2, 2024
Merged

feat: Enable mock mining in Epoch 3.0 #5029

merged 5 commits into from
Aug 2, 2024

Conversation

jbencin
Copy link
Contributor

@jbencin jbencin commented Jul 31, 2024

Description

Enable mock mining in 3.0 and add integration test for it

Applicable issues

Additional info (benefits, drawbacks, caveats)

Should I combine the mock_mining() integration test with follower_bootup() (it is based off that) or leave them separate?

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo
  • New integration test(s) added to bitcoin-tests.yml

@jbencin jbencin requested review from a team as code owners July 31, 2024 17:27
@jbencin jbencin requested review from obycode and kantai July 31, 2024 17:27
obycode
obycode previously approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good, just requesting some explanation on one section.

testnet/stacks-node/src/nakamoto_node/miner.rs Show resolved Hide resolved
kantai
kantai previously approved these changes Aug 1, 2024
View reviewed changes
obycode
obycode previously approved these changes Aug 1, 2024
View reviewed changes
@jbencin jbencin dismissed stale reviews from obycode and kantai via 32be29b August 2, 2024 13:37
@jbencin jbencin enabled auto-merge August 2, 2024 15:18
@jbencin jbencin requested review from kantai and obycode August 2, 2024 15:18
@jbencin jbencin added this pull request to the merge queue Aug 2, 2024
Merged via the queue into stacks-network:develop with commit 1d61f35 Aug 2, 2024
1 check passed
@jbencin jbencin deleted the feat/naka-mocka branch August 2, 2024 20:58
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Oct 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kantai kantai kantai approved these changes

@obycode obycode obycode approved these changes

Assignees
No one assigned
Labels
locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jbencin @blockstack-devops @kantai @obycode